minor: add fileGroup to V10 segment SegmentFileContainerMetadata, switch default metadata compression to zstd#19468
Merged
clintropolis merged 5 commits intoMay 18, 2026
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
Reviewed 7 of 7 changed files.
This is an automated review by Codex GPT-5.5
capistrant
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
fileGroupfield toSegmentFileContainerMetadataof V10 segments, which after #19375 associated containers withstartFileGroupto place all internal files under the same group in the same container. This just adds that field to the container so on the read side we have an easy way to get a list of the internal file bundles present in a v10 segment, making some things easier for partial download. The segment file builder now also enforces that columns and files added during a file group are prefixed with the file group name.While I was here, I also set the default metadata compression for v10 segments to use zstd instead of uncompressed. I can't really think of much downside to doing this, I just hadn't got around to switching it yet, so did it now since I had to update the expected size of a test anyway.