fix: web console services card missing broker count without SQL#19480
fix: web console services card missing broker count without SQL#19480wlswo wants to merge 1 commit into
Conversation
…lable The home dashboard's Services card has two code paths: the SQL path queries sys.servers (discovery-backed, so every node role is reported), while the coordinator-only fallback only counted historical, middle_manager, and peon. /druid/coordinator/v1/servers?simple does return brokers as well, but they were dropped before being passed to the card, so non-SQL deployments showed no broker count even when brokers were present. Add the broker count to the fallback so its output matches the SQL path.
|
Closing in favor of #19481 after verifying this against a live Druid 30 cluster.
So the broker filter added in this PR would always count zero. The real bug is broader: the coordinator-only fallback Sorry for the noise. |
Description
The home dashboard's Services card has two code paths. The SQL path queries
sys.servers(discovery-backed, so everynode role is reported), while the coordinator-only fallback only counted
historical,middle_manager, andpeon./druid/coordinator/v1/servers?simpledoes return brokers as well (brokers are tracked byInventoryView/ServerType.BROKER), but they were dropped before being passed to the card, so non-SQL deploymentsshowed no broker count even when brokers were present.
This change adds the broker count to the fallback so its output matches the SQL path.
The other roles missing from the fallback (
coordinator,overlord,router,indexer,middle_managervsindexer-executordistinction) cannot be derived from/druid/coordinator/v1/servers?simpleand would requireadditional endpoints; they are intentionally left out of this change.
Release note
The home view's Services card now correctly shows the broker count on clusters where the web console is talking to
the coordinator without SQL access.
Key changed/added classes in this PR
web-console/src/views/home-view/services-card/services-card.tsxThis PR has:
licenses.yaml (N/A — no dependency change)
reader. (N/A — one-line change)
coverage is met. (no new test —
existing snapshot test covers the SQL path; the fallback path is a one-line filter mirroring an existing line)
npm run typecheck/npm run jest/npm run eslint/npm run prettify-checkall pass)