minor: Get StorageMonitor metrics from StorageLocations.#19494
Merged
Conversation
This patch changes StorageMonitor to get metrics from StorageLocations directly, rather than through SegmentLocalCacheManager. This simplifies the logic by removing an unnecessary layer. It also ensures that metrics are reported properly no matter how the StorageLocations are accessed.
github-actions
Bot
added
Area - Batch Ingestion
Area - MSQ
Member
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
| Severity | Findings |
|---|---|
| P0 | 0 |
| P1 | 0 |
| P2 | 1 |
| P3 | 0 |
| Total | 1 |
Reviewed 9 of 9 changed files.
This is an automated review by Codex GPT-5.5
capistrant
reviewed
May 21, 2026
Contributor
capistrant
left a comment
capistrant
left a comment
There was a problem hiding this comment.
metrics parts +1. left non-stats question about the diff in SegmentLocalCacheManager
Comment on lines
+474
to
+476
| if (!config.isVirtualStorage()) { | ||
| return AcquireSegmentAction.missingSegment(); | ||
| } |
Contributor
There was a problem hiding this comment.
this feels off topic, can you provide some context? this also seems to make lines 486 to 488 below dead code, if it is indeed safe to hoist this block up out of the synchronized block
Contributor
Author
There was a problem hiding this comment.
Right, this isn't related to the main change, it's an opportunistic change to one of the related files. I'll pull it out and do it in a separate PR.
clintropolis
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes StorageMonitor to get metrics from StorageLocations directly, rather than through SegmentLocalCacheManager. This simplifies the logic by removing an unnecessary layer. It also ensures that metrics are reported properly no matter how the StorageLocations are accessed.