fix: fix chat handler response parsing#19495
Merged
gianm merged 2 commits intoMay 22, 2026
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Member
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
Reviewed 5 of 5 changed files.
This is an automated review by Codex GPT-5.5
gianm
reviewed
May 21, 2026
Contributor
gianm
left a comment
gianm
left a comment
There was a problem hiding this comment.
The change looks good to me. Could you update KubernetesTaskRunner too?
jtuglu1
force-pushed
the
fix-task-chat-handler-response-parsing
branch
from
4e272e2 to
690c6e6
Compare
gianm
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Overlord task report requests can sometimes be too eager during ingestion and ping a task before the http server servicing the chat requests has spun up. This causes 4xx/5xx to be returned, which are not correctly parsed by the chat client. While this doesn't explicitly fail the ingestion, it spams the logs and causes confusion.
This properly propagates the error code/body through to the response, so no parse exceptions occur.
Example:
Release note
Overlord task report requests can sometimes be too eager during ingestion and ping a task before the http server servicing the chat requests has spun up. This causes 4xx/5xx to be returned, which are not correctly parsed by the chat client. While this doesn't explicitly fail the ingestion, it spams the logs and causes confusion.
This PR has: