hll sketch to accept array as input#8619
Conversation
|
Ah, I suspect this issue is because I haven't yet quite finished all of the work of #7525 in #7588, namely that ingestion side support for array functions are not complete in that the part that should be coercing arrays back to lists is missing. Apologies this fact isn't better documented somewhere. This change might be able to make them work specifically for hll sketches though, however it looks like the added test is currently failing. |
| new ExpressionTransform( | ||
| "multiDimAppended", | ||
| "array_append(multiDim, '15')", | ||
| ExprMacroTable.nil() |
There was a problem hiding this comment.
@clintropolis yes, I guess you're right.
However I am still not able to make this test pass. Is there a simple way to run these tests?
Or maybe the issue is evident right away? I haven't found any test with transformations, I suppose this test implementation is flawed.
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions. |
|
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
2 participants
Fixes #8613.
Description
Adds
String[]support for HLL sketches generation.This fix lets customers use results of transformation as input for HLL Build aggregation.
This PR has:
Key changed/added classes in this PR
HllSketchBuildAggregator