null handling for doubles sketch and array of doubles sketch aggs#9112
Merged
jon-wei merged 2 commits intoapache:masterfrom Jan 7, 2020
Merged
null handling for doubles sketch and array of doubles sketch aggs#9112jon-wei merged 2 commits intoapache:masterfrom
jon-wei merged 2 commits intoapache:masterfrom
Conversation
…lls in sql compatible null handling mode
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Jan 8, 2020
…ache#9112) * doubles sketch and array of doubles sketch aggs now skip rows with nulls in sql compatible null handling mode * formatting
clintropolis
added a commit
that referenced
this pull request
Jan 9, 2020
) (#9148) * doubles sketch and array of doubles sketch aggs now skip rows with nulls in sql compatible null handling mode * formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Similar to #9073 and #9075, this PR modifies doubles sketch and array of doubles sketch aggregators to ignore null valued rows when SQL compatible null handling mode is enabled.
Note that it is still possible to treat
nullvalued rows as0in SQL compatible null handling mode if desired by the user, through using virtual columns withnvl, as illustrated in one of the added tests.This PR has: