fix web console data loader dimension types#9135
Merged
vogievetsky merged 1 commit intoapache:masterfrom Jan 7, 2020
Merged
Conversation
Contributor
|
thank you for this fix 👍 |
2 tasks
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Jan 8, 2020
clintropolis
added a commit
that referenced
this pull request
Jan 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with the web console data loader wizard, which is using all-caps types 'STRING', 'LONG', 'DOUBLE' when converting something it thinks is a metric into a dimension, which don't get correctly recognized by the dimension schema json deserialization, resulting in the column types defaulting to 'string'.
Additionally, the types presented in the type dropdown once converted to a dimension differ from the types available to convert a metric to ('string', 'long', 'float' vs 'STRING', 'LONG', 'DOUBLE').
These have been standardized to use 'string', 'long', 'float', 'double' in all the places.
This PR has: