Skip to content

Improved the readability and fixed few java warnings#9163

Merged
gianm merged 3 commits intoapache:masterfrom
mrsrinivas:fix-eq-warnings
Feb 21, 2020
Merged

Improved the readability and fixed few java warnings#9163
gianm merged 3 commits intoapache:masterfrom
mrsrinivas:fix-eq-warnings

Conversation

@mrsrinivas
Copy link
Contributor

@mrsrinivas mrsrinivas commented Jan 10, 2020

Description

Fixed the readability and fixed few java warnings


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

Key changed/added classes in this PR
  • sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/TimeArithmeticOperatorConversion.java
  • sql/src/main/java/org/apache/druid/sql/calcite/filtration/ConvertSelectorsToIns.java

@mrsrinivas
Copy link
Contributor Author

retest

Copy link
Contributor

@gianm gianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there is a checkstyle issue reported. Could you please look into this:

[INFO] --- maven-checkstyle-plugin:3.0.0:checkstyle (default-cli) @ druid-sql ---

[INFO] Starting audit...

[ERROR] /home/travis/build/apache/druid/sql/src/main/java/org/apache/druid/sql/calcite/expression/Expressions.java:268: 'else' child has incorrect indentation level 8, expected level should be 6. [Indentation]

@mrsrinivas
Copy link
Contributor Author

@gianm thank you for the review. I fixed it.

Copy link
Contributor

@gianm gianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gianm gianm merged commit 05258dc into apache:master Feb 21, 2020
@mrsrinivas mrsrinivas deleted the fix-eq-warnings branch February 22, 2020 05:40
@jihoonson jihoonson added this to the 0.18.0 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants