Drop the deprecated NoneShardSpec#9246
Conversation
|
This breaks compatibility with segments that were built with none shard spec. My understanding is that very old segments are still to be supported to load on historicals for query. |
|
Yes, this is an incompatible change. The |
|
I don't think we should ever remove support for loading any previously-existing segments, no matter how old they are. To my knowledge, we haven't done this since Druid was open-sourced (if I recall correctly, the pre-v8 segment versions were also pre-OSS). This is because it is a pretty big burden on users to ask them to reindex all their data. Does the fact that NoneShardSpec exists block #9241 from working? If so, an alternative would be to remove NoneShardSpec, but include code to automatically convert metadata into something equivalent, so users don't need to reindex. |
|
Ok. This is not a blocker. I'm closing this PR. |
A part of #9241.
NoneShardSpechas been deprecated for a while.This PR has: