Fix early return from YieldingSequenceBase#accumulate.#9293
Merged
ccaominh merged 1 commit intoapache:masterfrom Jan 30, 2020
Merged
Fix early return from YieldingSequenceBase#accumulate.#9293ccaominh merged 1 commit intoapache:masterfrom
ccaominh merged 1 commit intoapache:masterfrom
Conversation
ccaominh
approved these changes
Jan 30, 2020
| */ | ||
| public class LimitedSequenceTest | ||
| { | ||
| private static final List<Integer> NUMS = Arrays.asList(0, 1, 2, 3, 4, 5, 6, 7, 8, 9); |
Contributor
There was a problem hiding this comment.
Looks like this can also be used in testNoSideEffects()
Contributor
Author
|
By the way, for the record, I'm not sure if this bug has production impacts. I found it while working on some test cases for a different patch. A LimitedSequence I was using had a threshold of 2 but was only returning 1 element due to this early-return problem. |
gianm
added a commit
to gianm/druid
that referenced
this pull request
Jan 31, 2020
I think a mid-air collision between apache#9260 and apache#9293 has led to master being unable to pass insepctions in TeamCity. Hopefully this fixes it.
gianm
added a commit
that referenced
this pull request
Jan 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9291.