Get larger batch of input files when using native batch with google cloud#9307
Merged
jihoonson merged 1 commit intoapache:masterfrom Feb 4, 2020
Merged
Get larger batch of input files when using native batch with google cloud#9307jihoonson merged 1 commit intoapache:masterfrom
jihoonson merged 1 commit intoapache:masterfrom
Conversation
…loud By default native batch ingestion was only getting a batch of 10 files at a time when used with google cloud. The Default for other cloud providers is 1024, and should be similar for google cloud. The low batch size was caused by mistype. This change updates the batch size to 1024 when using google cloud.
clintropolis
approved these changes
Feb 4, 2020
|
|
||
| public class GoogleCloudStorageInputSourceTest extends InitializedNullHandlingTest | ||
| { | ||
| private static final long EXPECTED_MAX_LISTING_LENGTH = 1024L; |
Member
There was a problem hiding this comment.
nit: this should probably just use GoogleCloudStorageInputSource.MAX_LISTING_LENGTH directly in the event it ever changes
jihoonson
approved these changes
Feb 4, 2020
zachjsh
added a commit
to zachjsh/druid
that referenced
this pull request
Feb 6, 2020
…loud (apache#9307) By default native batch ingestion was only getting a batch of 10 files at a time when used with google cloud. The Default for other cloud providers is 1024, and should be similar for google cloud. The low batch size was caused by mistype. This change updates the batch size to 1024 when using google cloud.
zachjsh
added a commit
to implydata/druid-public
that referenced
this pull request
Feb 6, 2020
…loud (apache#9307) By default native batch ingestion was only getting a batch of 10 files at a time when used with google cloud. The Default for other cloud providers is 1024, and should be similar for google cloud. The low batch size was caused by mistype. This change updates the batch size to 1024 when using google cloud.
zachjsh
added a commit
to implydata/druid-public
that referenced
this pull request
Feb 7, 2020
…loud (apache#9307) (#52) By default native batch ingestion was only getting a batch of 10 files at a time when used with google cloud. The Default for other cloud providers is 1024, and should be similar for google cloud. The low batch size was caused by mistype. This change updates the batch size to 1024 when using google cloud.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By default native batch ingestion was only getting a batch of 10
files at a time when used with google cloud. The Default for other
cloud providers is 1024, and should be similar for google cloud.
The low batch size was caused by mistype. This change updates the
batch size to 1024 when using google cloud.
This PR has: