Skip to content

Add unit tests for CoordinatorRuleManager#9318

Merged
clintropolis merged 1 commit intoapache:masterfrom
jihoonson:coordinator-rule-manager-test
Feb 14, 2020
Merged

Add unit tests for CoordinatorRuleManager#9318
clintropolis merged 1 commit intoapache:masterfrom
jihoonson:coordinator-rule-manager-test

Conversation

@jihoonson
Copy link
Contributor

@jihoonson jihoonson commented Feb 6, 2020

See #9302 (comment).

FYI @zhenxiao @suneet-s.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

@zhenxiao
Copy link
Contributor

zhenxiao commented Feb 6, 2020

looks good

@clintropolis clintropolis merged commit bcf8f91 into apache:master Feb 14, 2020
@jihoonson jihoonson added this to the 0.18.0 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants