Use ExecutorService instead of ScheduledExecutorService where necessary#9325
Merged
jihoonson merged 2 commits intoapache:masterfrom Feb 12, 2020
Merged
Use ExecutorService instead of ScheduledExecutorService where necessary#9325jihoonson merged 2 commits intoapache:masterfrom
jihoonson merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
Hi @mgill25, thank you for your contribution. The change looks good to me, but technically this PR doesn’t fix the issue #9286 because it is about prohibiting this pattern by adding a new inspection rule. Are you interested in adding such a rule? If so please include the new rule in the PR. If not, please update the PR description to not include “Fixes #9286”. |
… to ExecutorService
Contributor
Author
|
@jihoonson My bad, I'm not too familiar with IntelliJ inspection, so I guess I missed it. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9286
Description
Changed the two instances mentioned in the PR to use
Execs.singleThreaded, which returns anExecutorService, instead of aScheduledExecutorService.I looked at the concurrency checklist (Threads and Executors section), but don't see anything immediate that I also need to do. Please correct me if I missed something.
This PR has: