Add Azure ingestion flow to web console#9437
Merged
vogievetsky merged 4 commits intoapache:masterfrom Mar 3, 2020
Merged
Conversation
Contributor
Can you indicate what this is blocked on? |
Contributor
Author
|
I just wasn’t sure if zachs stuff has been merged
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Vadim Ogievetsky <notifications@github.com>
Sent: Friday, February 28, 2020 7:47:24 PM
To: apache/druid <druid@noreply.github.com>
Cc: Maggie Brewster <mcbrewster@edu.uwaterloo.ca>; Author <author@noreply.github.com>
Subject: Re: [apache/druid] Add Azure ingestion flow to web console (#9437)
Please do not merge until support for azure has been merged
Can you indicate what this is blocked on?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#9437?email_source=notifications&email_token=AI4X64HHWD4XZGVFMMEC4FTRFHLEZA5CNFSM4K55KZIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENLC3DQ#issuecomment-592850318>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AI4X64DNID2UOBXZEVIUARDRFHLEZANCNFSM4K55KZIA>.
|
Contributor
|
I think you are referring to #9394 and it is merged! |
vogievetsky
reviewed
Feb 29, 2020
|
|
||
| case 'static-azure': | ||
| deepSet(spec, 'ioConfig.firehose.type', 'azure'); | ||
| break; |
Contributor
There was a problem hiding this comment.
There is no need for this upgrade spec clause, there was never a 'static-azure'. This is back compat code but Azure ingestion did not used to exist. You can just remove this change.
vogievetsky
reviewed
Feb 29, 2020
|
|
||
| case 'azure': | ||
| deepSet(spec, 'ioConfig.firehose.type', 'static-azure'); | ||
| break; |
Contributor
|
Looks great thank you 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

**Please do not merge until support for azure has been merged**Adds the ability to ingest data from azure via the web console. There is now a tile that allows the user to access the Azure ingestion flow if druid-azure-extensions is in the load list. The default input type will be azure. The user can then put a can then input data using A URI or a Prefix. the resulting IO config changes will be :
or
The user can configure the rest of the spec using the normal web console flow.
Additionally

azure is now available as an input type in the input menu for all flows