Skip to content

Fix history dialog overflow#9471

Merged
vogievetsky merged 2 commits intoapache:masterfrom
implydata:IMPLY-1661
Mar 10, 2020
Merged

Fix history dialog overflow#9471
vogievetsky merged 2 commits intoapache:masterfrom
implydata:IMPLY-1661

Conversation

@mcbrewster
Copy link
Contributor

@mcbrewster mcbrewster commented Mar 6, 2020

The class name for the history dialog wasn't being rendered by bluepint.js causing the css to be lost. Adding the classname as a separate div renders the css and prevents the dialog from overflowing.

Screen Shot 2020-03-06 at 11 22 34 AM

@mcbrewster mcbrewster changed the title [IMPLY-1661] fix history dialog overflow Fix history dialog overflow Mar 6, 2020
@jennyzzz
Copy link
Contributor

jennyzzz commented Mar 9, 2020

lgtm

@vogievetsky
Copy link
Contributor

Looks good. 👍

@vogievetsky vogievetsky merged commit 96ed721 into apache:master Mar 10, 2020
@vogievetsky vogievetsky deleted the IMPLY-1661 branch March 10, 2020 02:10
@jihoonson jihoonson added this to the 0.18.0 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants