Resource leak in DruidSegmentReader#9476
Merged
clintropolis merged 2 commits intoapache:masterfrom Mar 9, 2020
Merged
Conversation
b-slim
approved these changes
Mar 9, 2020
Contributor
b-slim
left a comment
There was a problem hiding this comment.
@jihoonson wondering how did you run into this ? is there a stack trace you can share ?
Contributor
Author
|
Hey @b-slim, thank you for the quick review. I was just lucky. I was looking at the codes around |
ccaominh
approved these changes
Mar 9, 2020
clintropolis
approved these changes
Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
Yieldershould be closed when it's done.This PR has: