Skip to content

Resource leak in DruidSegmentReader#9476

Merged
clintropolis merged 2 commits intoapache:masterfrom
jihoonson:close-yielder-segment-reader
Mar 9, 2020
Merged

Resource leak in DruidSegmentReader#9476
clintropolis merged 2 commits intoapache:masterfrom
jihoonson:close-yielder-segment-reader

Conversation

@jihoonson
Copy link
Contributor

Description

The Yielder should be closed when it's done.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

@jihoonson jihoonson added the Bug label Mar 8, 2020
Copy link
Contributor

@b-slim b-slim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jihoonson wondering how did you run into this ? is there a stack trace you can share ?

@jihoonson
Copy link
Contributor Author

Hey @b-slim, thank you for the quick review. I was just lucky. I was looking at the codes around Yielder and found it's not closed in DruidSegmentReader.

@clintropolis clintropolis merged commit f456d2f into apache:master Mar 9, 2020
@jihoonson jihoonson added this to the 0.18.0 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants