Web console: standardize the spec format#9477
Merged
vogievetsky merged 2 commits intoapache:masterfrom Mar 12, 2020
Merged
Conversation
jihoonson
reviewed
Mar 10, 2020
| "timestampSpec": Object { | ||
| "column": "timestamp", | ||
| "format": "iso", | ||
| "parser": Object { |
Contributor
There was a problem hiding this comment.
Hmm, this change seems like a rollback to the old spec. Is this intended?
Contributor
|
Other changes look good to me.. At least it works properly in my laptop. |
Contributor
Author
|
Sweet! Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9144
The main work is https://github.com/apache/druid/compare/master...implydata:spec-it?expand=1#diff-0a98d9c7441defdafcd0926835b640ddL42 the rest is making it all work.