Skip to content

improvement password provider markdown#9479

Closed
JiHyeongSeo wants to merge 1 commit intoapache:masterfrom
JiHyeongSeo:improvement-password-provider-markdown
Closed

improvement password provider markdown#9479
JiHyeongSeo wants to merge 1 commit intoapache:masterfrom
JiHyeongSeo:improvement-password-provider-markdown

Conversation

@JiHyeongSeo
Copy link

Description

Nowadays, using druid's password provider, I have experienced a lack of documentation. At least this change will not confuse other developers.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.


```json
{ "type": "environment", "variable": "METADATA_STORAGE_PASSWORD" }
druid.metadata.storage.type=mysql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

password provider can also be use in other places outside of the config files too. For example, the ingestionSpec. I think it's irrelevant to mention ...metadata.storage... stuff here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants