Skip to content

remove old unused zookeeper dependent lookups code#9480

Merged
himanshug merged 2 commits intoapache:masterfrom
himanshug:looks_zk_removal
Mar 10, 2020
Merged

remove old unused zookeeper dependent lookups code#9480
himanshug merged 2 commits intoapache:masterfrom
himanshug:looks_zk_removal

Conversation

@himanshug
Copy link
Contributor

@himanshug himanshug commented Mar 9, 2020

Paving Path Towards #9053

Description

This patch removes a bunch of lookups discovery code with hard coded use of Zookeeper. This code is no longer used at all and was originally kept to allow rolling upgrade transition to http based lookups management which is used currently by the coordinator for lookups management.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

@himanshug
Copy link
Contributor Author

@clintropolis thanks for quick review.

@himanshug himanshug merged commit 75a5591 into apache:master Mar 10, 2020
himanshug added a commit to himanshug/druid that referenced this pull request Mar 15, 2020
* remove old unused zookeeper dependent lookups code

* make  intellij inspector happy
@jihoonson jihoonson added this to the 0.18.0 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants