Skip to content

Change backtick(``) and fix broken links.#9550

Merged
clintropolis merged 1 commit intoapache:masterfrom
JaeGeunBang:docs/dev
Mar 24, 2020
Merged

Change backtick(``) and fix broken links.#9550
clintropolis merged 1 commit intoapache:masterfrom
JaeGeunBang:docs/dev

Conversation

@JaeGeunBang
Copy link
Contributor

Description

Sorry. The pull request below has a problem and sends a new pull request. (#9538)

@clintropolis
As suggested, Change backtick(``) links and fix broken links.

This PR has:

  • been self-reviewed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, now that I think about it, we probably don't want to actually add these files to git, because developers will likely modify them as needed for their environment and whatever they are testing, so should not be tracked.

If we do add them, they should probably be suffixed with example, so like this would be Coordinator-example.xml or something?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the link can just be [`.idea/misc.xml`](/.idea/misc.xml) since if it starts with / it treats it as the repository root.

dev/teamcity.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment: [`.idea/inspectionProfiles/Druid.xml`](/.idea/inspectionProfiles/Druid.xml)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we end up not adding the run configurations, I think this should not be a link, and just .idea/runConfigurations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clintropolis
Thank you!

Commit again based on your comments.

  • change backtick (``).
  • fix broken links.
  • no link .idea/runConfigurations
  • delete runConfiguration/ in /.idea

Copy link
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix! 👍

@clintropolis clintropolis added Area - Dev For items related to the project itself, like dev docs and checklists, but not CI Area - Documentation labels Mar 24, 2020
@clintropolis clintropolis merged commit 57018ad into apache:master Mar 24, 2020
@jihoonson jihoonson added this to the 0.18.0 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Dev For items related to the project itself, like dev docs and checklists, but not CI Area - Documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants