Skip to content

dont advise to rename to wikipedia-kafka#9598

Closed
AngryUbuntuNerd wants to merge 4 commits intoapache:masterfrom
AngryUbuntuNerd:patch-1
Closed

dont advise to rename to wikipedia-kafka#9598
AngryUbuntuNerd wants to merge 4 commits intoapache:masterfrom
AngryUbuntuNerd:patch-1

Conversation

@AngryUbuntuNerd
Copy link

Description

Removed the advise to rename datasource into "wikipedia-kafka" as this otherwise clashes with the linked follow-up tutorial in https://druid.apache.org/docs/latest/tutorials/tutorial-query.html. That one assumes the data source to be called simply "wikipedia".


This PR has:

  • been self-reviewed.

This otherwise clashes with the linked follow-up tutorial in https://druid.apache.org/docs/latest/tutorials/tutorial-query.html which assumes the data source to be called "wikipedia".
@surekhasaharan
Copy link

@AngryUbuntuNerd If we change "wikipedia-kafka" to "wikipedia", then the screenshots in https://druid.apache.org/docs/latest/tutorials/tutorial-kafka.html become misleading, I guess this change also requires redoing the screenshots.

@AngryUbuntuNerd
Copy link
Author

screenshots are updated, and additional text where mismatching the updated druid interface as well

@stale
Copy link

stale bot commented Jun 20, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Jun 20, 2020
@AngryUbuntuNerd
Copy link
Author

This PR is now ready to be merged - can a maintainer pick this up please?

@stale
Copy link

stale bot commented Jun 23, 2020

This issue is no longer marked as stale.

@stale stale bot removed the stale label Jun 23, 2020
@stale
Copy link

stale bot commented Aug 22, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Aug 22, 2020
@stale
Copy link

stale bot commented Sep 20, 2020

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale bot closed this Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants