Overlord and IndexingService validates externally received taskId#9666
Merged
gianm merged 1 commit intoapache:masterfrom Apr 10, 2020
Merged
Overlord and IndexingService validates externally received taskId#9666gianm merged 1 commit intoapache:masterfrom
gianm merged 1 commit intoapache:masterfrom
Conversation
Addresses issues flagged by https://lgtm.com/rules/5970070/
suneet-s
changed the title
gianm
approved these changes
Apr 10, 2020
suneet-s
added a commit
to suneet-s/druid
that referenced
this pull request
Apr 10, 2020
Addresses issues flagged by https://lgtm.com/rules/5970070/
jihoonson
pushed a commit
that referenced
this pull request
Apr 10, 2020
Addresses issues flagged by https://lgtm.com/rules/5970070/
JulianJaffePinterest
pushed a commit
to JulianJaffePinterest/druid
that referenced
this pull request
Jun 12, 2020
Addresses issues flagged by https://lgtm.com/rules/5970070/
suneet-s
added a commit
to suneet-s/druid
that referenced
this pull request
Jul 14, 2020
Addresses issues flagged by https://lgtm.com/rules/5970070/
suneet-s
added a commit
to suneet-s/druid
that referenced
this pull request
Jul 14, 2020
Addresses issues flagged by https://lgtm.com/rules/5970070/
suneet-s
added a commit
to implydata/druid-public
that referenced
this pull request
Jul 15, 2020
…ache#9630)(apache#9666) (#146) * Indexing Service validates externally received taskId (apache#9666) Addresses issues flagged by https://lgtm.com/rules/5970070/ * check paths used for shuffle intermediary data manager get and delete (apache#9630) * check paths used for shuffle intermediary data manager get and delete * add test * newline * meh Conflicts: server/src/test/java/org/apache/druid/segment/indexing/DataSchemaTest.java * Add validation for authenticator and authorizer name (apache#10106) * Add validation for authorizer name * fix deps * add javadocs * Do not use resource filters * Fix BasicAuthenticatorResource as well * Add integration tests * fix test * fix Conflicts: core/src/main/java/org/apache/druid/common/utils/IdUtils.java extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisor.java integration-tests/src/main/java/org/apache/druid/testing/utils/KafkaEventWriter.java integration-tests/src/test/java/org/apache/druid/tests/indexer/AbstractKafkaIndexerTest.java * Add commons-text to server dependencies Co-authored-by: Clint Wylie <cwylie@apache.org>
suneet-s
added a commit
to suneet-s/druid
that referenced
this pull request
Jul 16, 2020
Addresses issues flagged by https://lgtm.com/rules/5970070/
jon-wei
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 20, 2020
…ache#9630)(apache#9666) (#151) * Indexing Service validates externally received taskId (apache#9666) Addresses issues flagged by https://lgtm.com/rules/5970070/ * check paths used for shuffle intermediary data manager get and delete (apache#9630) * check paths used for shuffle intermediary data manager get and delete * add test * newline * meh Conflicts: server/src/test/java/org/apache/druid/segment/indexing/DataSchemaTest.java * Add validation for authenticator and authorizer name (apache#10106) * Add validation for authorizer name * fix deps * add javadocs * Do not use resource filters * Fix BasicAuthenticatorResource as well * Add integration tests * fix test * fix Conflicts: core/src/main/java/org/apache/druid/common/utils/IdUtils.java core/src/test/java/org/apache/druid/common/utils/IdUtilsTest.java extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/KafkaConsumerConfigs.java extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisor.java indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTask.java indexing-service/src/main/java/org/apache/druid/indexing/worker/IntermediaryDataManager.java integration-tests/src/test/java/org/apache/druid/tests/indexer/AbstractKafkaIndexerTest.java server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java * Add commons-text to server dependencies * remove unsupported endpoints from ITBasicAuthConfigurationTest Co-authored-by: Clint Wylie <cwylie@apache.org>
jon-wei
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 20, 2020
…ache#9630)(apache#9666) (#147) * Indexing Service validates externally received taskId (apache#9666) Addresses issues flagged by https://lgtm.com/rules/5970070/ * check paths used for shuffle intermediary data manager get and delete (apache#9630) * check paths used for shuffle intermediary data manager get and delete * add test * newline * meh Conflicts: server/src/test/java/org/apache/druid/segment/indexing/DataSchemaTest.java * Add validation for authenticator and authorizer name (apache#10106) * Add validation for authorizer name * fix deps * add javadocs * Do not use resource filters * Fix BasicAuthenticatorResource as well * Add integration tests * fix test * fix Conflicts: extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/endpoint/BasicAuthenticatorResource.java extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authorization/endpoint/BasicAuthorizerResource.java extensions-core/druid-basic-security/src/test/java/org/apache/druid/security/authentication/CoordinatorBasicAuthenticatorResourceTest.java indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractTask.java integration-tests/src/test/java/org/apache/druid/tests/security/ITBasicAuthConfigurationTest.java server/src/main/java/org/apache/druid/segment/indexing/DataSchema.java server/src/test/java/org/apache/druid/segment/indexing/DataSchemaTest.java extensions-core/druid-basic-security/src/test/java/org/apache/druid/security/basic/authorization/endpoint/BasicAuthorizerResourceTest.java indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamIndexTask.java * Add commons-text to server dependencies * remove unsupported endpoints from ITBasicAuthConfigurationTest Co-authored-by: Clint Wylie <cwylie@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issues flagged by https://lgtm.com/rules/5970070/ by using the validation done in #9630