Skip to content

druid-basic-security ext: coordinator pollers to print informative logs on request failure#9676

Closed
himanshug wants to merge 1 commit intoapache:masterfrom
himanshug:bugfix
Closed

druid-basic-security ext: coordinator pollers to print informative logs on request failure#9676
himanshug wants to merge 1 commit intoapache:masterfrom
himanshug:bugfix

Conversation

@himanshug
Copy link
Contributor

Description

Currently if CoordinatorPollingBasic[Authenticator|Authorizer]CacheManager requests to coordinators fail then jackson deserialization or NPE etc exceptions are printed not helping figure out what the issue is.
in one case I had a typo in escalator config at router and coordinator was rejecting the request, it was not clear from the router logs why it wasn't starting up successfully.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

@stale
Copy link

stale bot commented Jun 10, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Jun 10, 2020
@stale
Copy link

stale bot commented Jul 10, 2020

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale bot closed this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant