Test for numeric timestamp parser with string timestamp#9888
Closed
suneet-s wants to merge 1 commit intoapache:masterfrom
Closed
Test for numeric timestamp parser with string timestamp#9888suneet-s wants to merge 1 commit intoapache:masterfrom
suneet-s wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@samarthjain - I added a test case for #9877 - I think this is the intended behavior. Can you confirm? |
samarthjain
reviewed
May 18, 2020
| Assert.assertEquals("Timestamp of format millis not parsed correctly", | ||
| Assert.assertEquals("Timestamp of format millis as long not parsed correctly", | ||
| expectedDt, parser.apply(millis)); | ||
| Assert.assertEquals("Timestamp of format millis as string not parsed correctly", |
Contributor
There was a problem hiding this comment.
@suneet-s - this test case passes fine without the fix in #9877. #9877 was meant for use cases where the ingested column storing time is a numeric column (int, long) that stores time in a format that isn't auto || millis || posix || micro || nano || ruby. If the column is of type string, then the timestamp parser parses the time correctly.
Contributor
Author
There was a problem hiding this comment.
@samarthjain makes sense. I initially thought this was a missing test case before your pr. Looking more closely at the tests, I see this is covered by TimestampParserTest#testNano
Closing this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.