Skip to content

add: tls sample#68

Merged
AlexStocks merged 6 commits intoapache:masterfrom
cjphaha:tls
Mar 30, 2021
Merged

add: tls sample#68
AlexStocks merged 6 commits intoapache:masterfrom
cjphaha:tls

Conversation

@cjphaha
Copy link
Copy Markdown
Member

@cjphaha cjphaha commented Mar 14, 2021

No description provided.

@AlexStocks AlexStocks requested a review from aliiohs March 15, 2021 00:07
Comment thread tls/go-client/app/client.go
Comment thread tls/go-client/app/user.go Outdated
Comment thread tls/go-client/app/env.sh Outdated
Comment thread tls/go-client/app/start.sh Outdated
@@ -0,0 +1,3 @@
export CONF_CONSUMER_FILE_PATH="../conf/client.yml"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid use shell script to start. try if build/makefile work or not. pls. refer to HOWTO.md

Comment thread tls/go-server/app/env.sh Outdated
Comment thread tls/go-server/app/server.go
Comment thread tls/go-server/app/start.sh Outdated
Comment thread tls/go-server/app/user.go Outdated
@@ -0,0 +1,47 @@
package main
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls. add apache license header.

Comment thread tls/go-server/app/version.go Outdated
Comment thread tls/go-client/cmd/client.go Outdated
Comment thread tls/go-client/conf/client.yml Outdated

references:
"UserProvider":
# 可以指定多个registry,使用逗号隔开;不指定默认向所有注册中心注册
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line of comment.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove this line? maybe we can translate it into english.

Comment thread tls/go-client/pkg/user.go
Comment thread tls/go-server/cmd/server.go Outdated
Comment thread tls/go-server/cmd/server.go Outdated
Comment thread tls/go-server/cmd/server.go Outdated
Comment thread tls/go-server/cmd/server.go Outdated
Comment thread tls/go-server/cmd/server.go Outdated
Comment thread tls/go-server/conf/server.yml Outdated
Comment thread tls/go-server/conf/server.yml Outdated
Comment thread tls/README.md Outdated
Comment thread tls/README_zh.md Outdated
Comment thread tls/go-server/pkg/user.go Outdated
Comment thread tls/go-server/pkg/user.go Outdated
Copy link
Copy Markdown
Contributor

@zhaoyunxing92 zhaoyunxing92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved these changes

@AlexStocks AlexStocks merged commit 091a70a into apache:master Mar 30, 2021
LaurenceLiZhixin pushed a commit to LaurenceLiZhixin/dubbo-go-samples that referenced this pull request Jul 7, 2021
zhaoyunxing92 pushed a commit that referenced this pull request Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants