test: enhance triple stream validation in unit tests #3152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3152 +/- ##
========================================
Coverage 47.80% 47.80%
========================================
Files 460 460
Lines 33011 33011
========================================
Hits 15782 15782
+ Misses 15963 15962 -1
- Partials 1266 1267 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the TestStreamForServer test by ensuring the client stream is properly established before testing stream operations. The change improves test reliability by following the same pattern used in the adjacent "client-stream" test case.
- Adds a
stream.Receive()call in the "client-stream-conn" test to consume the client's message before attempting server operations - Includes comments explaining the purpose of receiving the message and testing the non-proto send operation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlexStocks
approved these changes
Jan 8, 2026
Contributor
|
LGTM |
nanjiek
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3149
This pull request makes a minor improvement to the
TestStreamForServertest by ensuring that the client stream is properly established before attempting to send a non-protobuf message. This helps verify the correct behavior of the stream handling logic.triple_ext_test.go, the test now explicitly receives the client's message before sending a non-proto message, ensuring the stream is established and making the test more reliable.Checklist
develop