Skip to content

fix:nacos client_test bug#363

Merged
AlexStocks merged 4 commits intoapache:developfrom
amudong:develop
Feb 22, 2020
Merged

fix:nacos client_test bug#363
AlexStocks merged 4 commits intoapache:developfrom
amudong:develop

Conversation

@amudong
Copy link
Contributor

@amudong amudong commented Feb 17, 2020

fix:nacos client_test bug

@zouyx
Copy link
Member

zouyx commented Feb 18, 2020

format config_center/nacos/client_test.go then make travis succes

@codecov-io
Copy link

codecov-io commented Feb 18, 2020

Codecov Report

Merging #363 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #363      +/-   ##
===========================================
- Coverage    66.74%   66.72%   -0.03%     
===========================================
  Files          150      150              
  Lines         7936     7963      +27     
===========================================
+ Hits          5297     5313      +16     
- Misses        2137     2146       +9     
- Partials       502      504       +2
Impacted Files Coverage Δ
protocol/dubbo/dubbo_invoker.go 82.25% <0%> (-7.11%) ⬇️
cluster/cluster_impl/failback_cluster_invoker.go 78.49% <0%> (-2.16%) ⬇️
registry/directory/directory.go 82.69% <0%> (-0.87%) ⬇️
remoting/zookeeper/listener.go 52.57% <0%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0d3ac1...98afe2c. Read the comment docs.

@zouyx
Copy link
Member

zouyx commented Feb 20, 2020

Travis still failing @amudong

@AlexStocks
Copy link
Contributor

LGTM

@AlexStocks AlexStocks merged commit 6b26d4b into apache:develop Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants