Skip to content

Fix/ignore apollo prop file#372

Closed
swr1bm86 wants to merge 1 commit intoapache:masterfrom
swr1bm86:fix/ignore-apollo-prop-file
Closed

Fix/ignore apollo prop file#372
swr1bm86 wants to merge 1 commit intoapache:masterfrom
swr1bm86:fix/ignore-apollo-prop-file

Conversation

@swr1bm86
Copy link
Contributor

@swr1bm86 swr1bm86 commented Feb 24, 2020

after ut, apollo will generate a trivial config file.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	config_center/apollo/mockDubbog.properties.json

@swr1bm86 swr1bm86 force-pushed the fix/ignore-apollo-prop-file branch from e25bd32 to 7f57dfd Compare February 24, 2020 00:18
@swr1bm86 swr1bm86 force-pushed the fix/ignore-apollo-prop-file branch from 7f57dfd to 41c3e8e Compare February 24, 2020 00:23
@codecov-io
Copy link

Codecov Report

Merging #372 into master will decrease coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #372      +/-   ##
==========================================
- Coverage   67.16%   66.69%   -0.47%     
==========================================
  Files         145      145              
  Lines        7692     7692              
==========================================
- Hits         5166     5130      -36     
- Misses       2036     2072      +36     
  Partials      490      490
Impacted Files Coverage Δ
protocol/dubbo/listener.go 56.75% <0%> (-6.49%) ⬇️
protocol/dubbo/pool.go 74.77% <0%> (-6.43%) ⬇️
protocol/dubbo/client.go 63.75% <0%> (-5%) ⬇️
cluster/cluster_impl/failback_cluster_invoker.go 78.49% <0%> (-2.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33f82cd...41c3e8e. Read the comment docs.

@AlexStocks
Copy link
Contributor

@zjhmale thx for your pr. the target branch should be develop. thank you.

@zouyx
Copy link
Member

zouyx commented Feb 24, 2020

@zjhmale thanks for your PR. In develop branch, UT will delete this file once it finish. you can try it.

func deleteMockJson(t *testing.T) {

@swr1bm86
Copy link
Contributor Author

ok, thanks for the hint, will checkout develop then

@swr1bm86 swr1bm86 closed this Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants