Skip to content

change log#374

Merged
flycash merged 3 commits intoapache:developfrom
pantianying:ftr_log
Feb 26, 2020
Merged

change log#374
flycash merged 3 commits intoapache:developfrom
pantianying:ftr_log

Conversation

@pantianying
Copy link
Copy Markdown
Member

What this PR does:

Optimized logs,Easy to troubleshoot

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link
Copy Markdown

codecov-io commented Feb 25, 2020

Codecov Report

Merging #374 into develop will decrease coverage by 0.14%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #374      +/-   ##
===========================================
- Coverage    66.72%   66.57%   -0.15%     
===========================================
  Files          150      150              
  Lines         7963     7964       +1     
===========================================
- Hits          5313     5302      -11     
- Misses        2146     2160      +14     
+ Partials       504      502       -2
Impacted Files Coverage Δ
remoting/zookeeper/client.go 68.06% <0%> (ø) ⬆️
registry/zookeeper/listener.go 60.86% <0%> (ø) ⬆️
common/proxy/proxy.go 95.87% <100%> (ø) ⬆️
registry/directory/directory.go 82.8% <100%> (+0.11%) ⬆️
protocol/dubbo/pool.go 76.6% <100%> (ø) ⬆️
protocol/dubbo/dubbo_invoker.go 82.25% <100%> (ø) ⬆️
remoting/zookeeper/listener.go 52.57% <100%> (ø) ⬆️
config_center/nacos/facade.go 35.29% <0%> (-29.42%) ⬇️
cluster/cluster_impl/base_cluster_invoker.go 62.31% <0%> (-10.15%) ⬇️
config_center/nacos/client.go 55.55% <0%> (-1.71%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1a3c2...6573221. Read the comment docs.

Copy link
Copy Markdown
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flycash flycash merged commit ff8ea17 into apache:develop Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants