Fix remoting/etcdv3/client test cases#375
Conversation
|
Thanks for your fisrt contirbution, should make travis succes @zjhmale |
swr1bm86
force-pushed
the
improve/remoting-etcdv3-specs
branch
from
a51bc40 to
2a15f0b
Compare
|
@zouyx pls review again :) |
remoting/etcdv3/client_test.go
Outdated
| e1 := events[0] | ||
| e2 := events[1] | ||
|
|
||
| if e1.Type != mvccpb.PUT || string(e1.Kv.Key) != "name" || string(e1.Kv.Value) != "scott.wang" { |
There was a problem hiding this comment.
| if e1.Type != mvccpb.PUT || string(e1.Kv.Key) != "name" || string(e1.Kv.Value) != "scott.wang" { | |
| assert.Contains() |
if array is not always sorting, suggest use assert.Contains()
There was a problem hiding this comment.
thanks for the hint, but for the sake of event queue semantic, the watching channel should be a sequential generator which means the event created in the first place should always be the first one consumed outside the watching channel IIRC, maybe I'm wrong.
remoting/etcdv3/client_test.go
Outdated
|
|
||
| e1 := events[0] | ||
| e2 := events[1] | ||
| if e1.Type != mvccpb.PUT || string(e1.Kv.Key) != "scott/wang" || e1.Kv.Value != nil { |
swr1bm86
force-pushed
the
improve/remoting-etcdv3-specs
branch
from
2a15f0b to
6e92af9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #375 +/- ##
===========================================
- Coverage 66.72% 66.36% -0.36%
===========================================
Files 150 150
Lines 7963 7964 +1
===========================================
- Hits 5313 5285 -28
- Misses 2146 2178 +32
+ Partials 504 501 -3
Continue to review full report at Codecov.
|
6 participants
Add up more assertations for the etcdv3 client.