Conversation
zouyx
reviewed
Apr 17, 2020
config/config_loader.go
Outdated
Comment on lines
204
to
208
| if confRouterFile != "" { | ||
| if errPro := RouterInit(confRouterFile); errPro != nil { | ||
| log.Printf("[routerConfig init] %#v", errPro) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
how about add more private function for router config file?
flycash
reviewed
Apr 18, 2020
Member
flycash
left a comment
flycash
left a comment
There was a problem hiding this comment.
using new private function to load router config
zouyx
approved these changes
Apr 18, 2020
flycash
approved these changes
Apr 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Divide load process to consumer && provider processes
Add comment for URLEqual
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: