Skip to content

refactor DubboAppenderTest #10250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlbumenJ merged 1 commit into from
Jul 1, 2022
Merged

refactor DubboAppenderTest #10250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 19 additions & 20 deletions dubbo-common/src/test/java/org/apache/dubbo/common/utils/DubboAppenderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,25 +23,25 @@
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.mockito.Mockito;

import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.hasSize;
import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.hasSize;
import static org.hamcrest.Matchers.equalTo;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
import static org.junit.jupiter.api.Assumptions.assumeFalse;
import static org.junit.jupiter.api.Assumptions.assumeTrue;

public class DubboAppenderTest {
private LoggingEvent event;

@BeforeEach
public void setUp() throws Exception {
Level level = Mockito.mock(Level.class);
Category category = Mockito.mock(Category.class);
event = Mockito.mock(LoggingEvent.class);
Mockito.when(event.getLogger()).thenReturn(category);
Mockito.when(event.getLevel()).thenReturn(level);
Mockito.when(event.getThreadName()).thenReturn("thread-name");
Mockito.when(event.getMessage()).thenReturn("message");
event = mock(LoggingEvent.class);
when(event.getLogger()).thenReturn(mock(Category.class));
when(event.getLevel()).thenReturn(mock(Level.class));
when(event.getThreadName()).thenReturn("thread-name");
when(event.getMessage()).thenReturn("message");
}

@AfterEach
Expand All @@ -51,33 +51,32 @@ public void tearDown() throws Exception {
}

@Test
public void testAvailable() throws Exception {
assertThat(DubboAppender.available, is(false));
public void testAvailable() {
assumeFalse(DubboAppender.available);
DubboAppender.doStart();
assertThat(DubboAppender.available, is(true));
DubboAppender.doStop();
assertThat(DubboAppender.available, is(false));
}

@Test
public void testAppend() throws Exception {
public void testAppend() {
DubboAppender appender = new DubboAppender();
appender.append(event);
assertThat(DubboAppender.logList, hasSize(0));
assumeTrue(0 == DubboAppender.logList.size());
DubboAppender.doStart();
appender.append(event);
assertThat(DubboAppender.logList, hasSize(1));
Log log = DubboAppender.logList.get(0);
assertThat(log.getLogThread(), equalTo("thread-name"));
assertThat(DubboAppender.logList.get(0).getLogThread(), equalTo("thread-name"));
}

@Test
public void testClear() throws Exception {
public void testClear() {
DubboAppender.doStart();
DubboAppender appender = new DubboAppender();
appender.append(event);
// assertThat(DubboAppender.logList, hasSize(1));
assumeTrue(1 == DubboAppender.logList.size());
DubboAppender.clear();
// assertThat(DubboAppender.logList, hasSize(0));
assertThat(DubboAppender.logList, hasSize(0));
}
}