Fix AwaitingNonWebApplicationListener await with parent context #15971
+672
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
code format issue should be fixed by running |
…pache#15974) * test: clarify unsupported IPv6 behavior in NetUtils * test: added IPV6 edgecase, fixed ambigious CIDR testcase
* support disableAutoInboundFlowControl api * support back press * fix * fix * Update dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/observer/CallStreamObserver.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/transport/TripleHttp2LocalFlowController.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/call/ClientCall.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update dubbo-common/src/main/java/org/apache/dubbo/config/nested/TripleConfig.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/call/ClientCall.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix * fix * fix test * add isReady and setOnReadyHandler api * fix * fix * fix Backpressure it * fix * fix * ClientCallStreamObserver & ServerCallStreamObserver * add license * mvn spotless:apply * fix dubbo plugin * fix dubbo plugin spotless * fix * fix ut * Add gRPC-compatible APIs and fix the integration tests * fix * fix * remove default * remove default --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Rain Yu <rainyu@apache.org> Co-authored-by: Wang Chengming <wangchengming@apache.org>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 3.3 #15971 +/- ##
============================================
- Coverage 60.70% 58.73% -1.98%
+ Complexity 11708 15 -11693
============================================
Files 1946 1948 +2
Lines 88701 88732 +31
Branches 13374 13379 +5
============================================
- Hits 53849 52117 -1732
- Misses 29342 30977 +1635
- Partials 5510 5638 +128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AwaitingNonWebApplicationListener should only enter the await state for the
root, non-web ApplicationContext.
When a parent–child context hierarchy is present, the listener must not await
during child context shutdown.
This PR ensures the listener behaves correctly with multiple non-web
application contexts and adds a focused regression test to cover this scenario.
Changes
Prevent awaiting logic from being triggered by child ApplicationContext
Add unit test for non-web parent–child context lifecycle
Testing
Added testMultipleContextNonWebApplication
Tests pass locally
Fixes #13722
please review it sir when you get time @AlbumenJ @RainYuY