Skip to content

introduce private method to remove duplicated codes#16218

Open
aaaZayne wants to merge 1 commit intoapache:3.3from
aaaZayne:clone-revise
Open

introduce private method to remove duplicated codes#16218
aaaZayne wants to merge 1 commit intoapache:3.3from
aaaZayne:clone-revise

Conversation

@aaaZayne
Copy link
Copy Markdown

Refactor parameter retrieval methods in Parameters class to remove clones.

Checklist

@zrlw zrlw changed the title introduce private method to remove clones introduce private method to remove duplicated codes Apr 20, 2026
Copy link
Copy Markdown
Contributor

@zrlw zrlw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 20, 2026

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.78%. Comparing base (d95086c) to head (a887760).
⚠️ Report is 31 commits behind head on 3.3.

Files with missing lines Patch % Lines
.../main/java/org/apache/dubbo/common/Parameters.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #16218      +/-   ##
============================================
- Coverage     60.79%   60.78%   -0.01%     
- Complexity    11751    11758       +7     
============================================
  Files          1953     1953              
  Lines         89119    89110       -9     
  Branches      13444    13440       -4     
============================================
- Hits          54179    54166      -13     
- Misses        29369    29371       +2     
- Partials       5571     5573       +2     
Flag Coverage Δ
integration-tests-java21 32.17% <0.00%> (-0.01%) ⬇️
integration-tests-java8 32.23% <0.00%> (+0.03%) ⬆️
samples-tests-java21 32.16% <0.00%> (+0.04%) ⬆️
samples-tests-java8 29.85% <0.00%> (-0.01%) ⬇️
unit-tests-java11 59.02% <0.00%> (-0.01%) ⬇️
unit-tests-java17 58.54% <0.00%> (+<0.01%) ⬆️
unit-tests-java21 58.54% <0.00%> (+0.02%) ⬆️
unit-tests-java25 58.50% <0.00%> (+0.02%) ⬆️
unit-tests-java8 59.05% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants