Skip to content

2.7.5 release#5659

Closed
ghost wants to merge 29 commits into
masterfrom
2.7.5-release
Closed

2.7.5 release#5659
ghost wants to merge 29 commits into
masterfrom
2.7.5-release

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 16, 2020

What is the purpose of the change

org.apache.dubbo.common.extension.ExtensionLoader#cacheDefaultExtensionName
Remove unnecessary logical judgments,i think there is a default extension name on extension ,it should't split with pattern.

Verifying this change

 private void cacheDefaultExtensionName() {
         final SPI defaultAnnotation = type.getAnnotation(SPI.class);
         if (defaultAnnotation == null) {
             return;
         }
         String value = defaultAnnotation.value();
         if ((value = value.trim()).length() > 0) {
             cachedDefaultName = value;
            /* String[] names = NAME_SEPARATOR.split(value);
             if (names.length > 1) {
                 throw new IllegalStateException("More than 1 default extension name on extension " + type.getName()
                         + ": " + Arrays.toString(names));
             }
             if (names.length == 1) {
                 cachedDefaultName = names[0];
             }*/
         }
     }

chickenlj and others added 29 commits November 27, 2019 09:49
# Conflicts:
#	dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/GrpcOptionsUtils.java
#	dubbo-rpc/dubbo-rpc-grpc/src/main/java/org/apache/dubbo/rpc/protocol/grpc/GrpcProtocol.java
…tion but with EnableDubbo/EnableDubboLifecycle not enabled (#5496)

Fixes #5495
@ghost ghost closed this Jan 16, 2020
@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 16, 2020

operate error

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants