Skip to content

Refactor, configuration override does not work properly.#5709

Merged
chickenlj merged 10 commits intoapache:masterfrom
chickenlj:configuration-refresh
Feb 20, 2020
Merged

Refactor, configuration override does not work properly.#5709
chickenlj merged 10 commits intoapache:masterfrom
chickenlj:configuration-refresh

Conversation

@chickenlj
Copy link
Contributor

Fixes #5224

@codecov-io
Copy link

codecov-io commented Feb 6, 2020

Codecov Report

Merging #5709 into master will decrease coverage by 0.11%.
The diff coverage is 98.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #5709      +/-   ##
===========================================
- Coverage     61.51%   61.4%   -0.12%     
- Complexity      491     495       +4     
===========================================
  Files           926     929       +3     
  Lines         37852   38016     +164     
  Branches       5463    5459       -4     
===========================================
+ Hits          23284   23342      +58     
- Misses        12046   12143      +97     
- Partials       2522    2531       +9
Impacted Files Coverage Δ Complexity Δ
...pache/dubbo/common/config/SystemConfiguration.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...che/dubbo/common/config/InmemoryConfiguration.java 84.61% <100%> (-1.1%) 0 <0> (ø)
...va/org/apache/dubbo/common/config/Environment.java 97.33% <100%> (+1.38%) 0 <0> (ø) ⬇️
.../dubbo/common/config/EnvironmentConfiguration.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...e/dubbo/common/config/PropertiesConfiguration.java 94.44% <100%> (+9.44%) 0 <0> (ø) ⬇️
...n/java/org/apache/dubbo/config/AbstractConfig.java 72.72% <100%> (-1%) 0 <0> (ø)
...bbo/config/context/ConfigConfigurationAdapter.java 100% <100%> (ø) 0 <0> (ø) ⬇️
...he/dubbo/common/config/CompositeConfiguration.java 69.76% <93.75%> (+7.69%) 0 <0> (ø) ⬇️
.../org/apache/dubbo/rpc/model/ServiceRepository.java 63.63% <0%> (-14.42%) 0% <0%> (ø)
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) 0% <0%> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bc4508...c8351c7. Read the comment docs.

@chickenlj chickenlj added this to the 2.7.6 milestone Feb 11, 2020
@chickenlj
Copy link
Contributor Author

reviewed by issue reporters

@chickenlj chickenlj merged commit 12d99d6 into apache:master Feb 20, 2020
seedeed pushed a commit to seedeed/dubbo that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dubbo.registry.address会覆盖一切自定义注册中心的值

2 participants