Skip to content

fix(geo): use label.formatter instead of label.normal.formatter#10201

Closed
Ende93 wants to merge 2 commits into
apache:masterfrom
Ende93:geoLabelFix
Closed

fix(geo): use label.formatter instead of label.normal.formatter#10201
Ende93 wants to merge 2 commits into
apache:masterfrom
Ende93:geoLabelFix

Conversation

@Ende93
Copy link
Copy Markdown
Contributor

@Ende93 Ende93 commented Apr 2, 2019

fix #10191

Comment thread src/coord/geo/GeoModel.js Outdated
@Ende93
Copy link
Copy Markdown
Contributor Author

Ende93 commented Apr 5, 2019

demo is here, see console and hover map can see the effect

@shenshuai89
Copy link
Copy Markdown

@Ende93 I use “npm install echarts --save” run this change,then happen an error “Error in mounted hook: "TypeError: mapSeries.getDataParams is not a function"

@Ende93
Copy link
Copy Markdown
Contributor Author

Ende93 commented Apr 10, 2019

@shenshuai89 can you provide demo ?

@Ende93
Copy link
Copy Markdown
Contributor Author

Ende93 commented Apr 10, 2019

@shenshuai89 your echarts's version seem like 4.1.0 which dont have getDataParams function, please try 4.2.1.

@shenshuai89
Copy link
Copy Markdown

there are still the same errors

@Ende93
Copy link
Copy Markdown
Contributor Author

Ende93 commented Apr 10, 2019

@shenshuai89 hmm, can you give a readable repo? so I can debug it

@shenshuai89
Copy link
Copy Markdown

https://github.com/shenshuai89/echartDemo
this is project。

@Ende93
Copy link
Copy Markdown
Contributor Author

Ende93 commented Apr 10, 2019

https://github.com/shenshuai89/echartDemo
this is project。

Sorry, seem you use 4.2.1 echarts that published, so I still cant see what happend. Can you use my branch code to do the test or show full code?

@shenshuai89
Copy link
Copy Markdown

shenshuai89 commented Apr 10, 2019

thanks

@plainheart plainheart added stale Inactive for a long time. Will be closed in 7 days. and removed PR: awaiting review labels Apr 20, 2021
@stale
Copy link
Copy Markdown

stale Bot commented Apr 20, 2021

This issue is marked to be stale and is going to be closed within a week. If you think it shouldn't be closed, please leave a comment.

@stale stale Bot removed the stale Inactive for a long time. Will be closed in 7 days. label Apr 20, 2021
@plainheart plainheart closed this May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

map series 使用 geoIndex 指定 geo 组件时,geo 的 label.formatter 属性失效

5 participants