Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(i18n): add translations of FI/ES/TH for time formatter. #13055

Merged
merged 3 commits into from Jul 31, 2020
Merged

feat(i18n): add translations of FI/ES/TH for time formatter. #13055

merged 3 commits into from Jul 31, 2020

Conversation

plainheart
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

add translations of FI/ES/TH languages for time formatter.

Fixed issues

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jul 31, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Ovilia
Ovilia requested changes Jul 31, 2020
View changes
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Among these languages, I only know about some Spanish. So I only reviewed the Spanish part.
Glad to help with my limited knowledge of Spanish. ;)

i18n/langES-obj.js Outdated Show resolved Hide resolved
src/i18n/langES.ts Outdated Show resolved Hide resolved
Ovilia
Ovilia reviewed Jul 31, 2020
View changes
Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ovilia Ovilia self-requested a review July 31, 2020 01:16
Ovilia
Ovilia approved these changes Jul 31, 2020
View changes
@pissang pissang merged commit f16a541 into apache:next Jul 31, 2020
@echarts-bot
Copy link

echarts-bot bot commented Jul 31, 2020

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the chore-fix branch January 27, 2021 09:54
@plainheart plainheart mentioned this pull request Oct 25, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ovilia Ovilia Ovilia approved these changes

@pissang pissang pissang approved these changes

Assignees
No one assigned
Labels
PR: author is committer size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@plainheart @Ovilia @pissang