Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(sankey): sankey label has higher z2 #14417

Merged
merged 1 commit into from Mar 8, 2021
Merged

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Mar 7, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Set sankey label z2 property.

Fixed issues

Close #14287

Details

Before: What was the problem?

Screen Shot 2021-03-07 at 22 56 11

After: How is it fixed in this PR?

Screen Shot 2021-03-07 at 22 55 57

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

sankey-vertical.html

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Mar 7, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang merged commit 31a6de8 into apache:master Mar 8, 2021
@echarts-bot
Copy link

echarts-bot bot commented Mar 8, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@@ -250,7 +250,8 @@ class SankeyView extends ChartView {
width: layout.dx,
height: layout.dy
},
style: itemModel.getModel('itemStyle').getItemStyle()
style: itemModel.getModel('itemStyle').getItemStyle(),
z2: 10
Copy link
Member

@plainheart plainheart Apr 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pissang @susiwen8 Sorry here. I ever reverted it in #14542. But for now, this change seems to be still needed or there is something extra to do like ab5838e?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plainheart Seems so, do you mind adding it before we vote for this release?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. It's here. #14640

plainheart added a commit that referenced this pull request Apr 10, 2021
fix(sankey): make label in the front of rect, recover the change of #14417.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECharts Sankey: Labels are hidden under lines with line emphasis
3 participants