Skip to content

fix(types) export DataItem from LegendModel#15241

Closed
gaetancollaud wants to merge 1 commit intoapache:masterfrom
gaetancollaud:bugfix/export-data-item
Closed

fix(types) export DataItem from LegendModel#15241
gaetancollaud wants to merge 1 commit intoapache:masterfrom
gaetancollaud:bugfix/export-data-item

Conversation

@gaetancollaud
Copy link
Copy Markdown

@gaetancollaud gaetancollaud commented Jun 25, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

This PR export the DataItem interface from LegendModel.ts. I guess it was an oversight.

Fixed issues

No issue opened

Details

Before: What was the problem?

Unable to fully use the type LegendOption

After: How is it fixed in this PR?

I can use DataItem to describe the legends

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link
Copy Markdown

echarts-bot bot commented Jun 25, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@gaetancollaud
Copy link
Copy Markdown
Author

Closing this since no response from the maintainers in 1 year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant