fix(treemap): remove old nodes on disabled animation#15283
Merged
pissang merged 2 commits intoapache:masterfrom Jul 3, 2021
Merged
fix(treemap): remove old nodes on disabled animation#15283pissang merged 2 commits intoapache:masterfrom
pissang merged 2 commits intoapache:masterfrom
Conversation
|
Thanks for your contribution! The pull request is marked to be |
pissang
approved these changes
Jul 3, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
animationis set tofalseontreemap,renderFinally()isn't called when callingsetOptionfor the second time.Brief Information
This pull request is in the type of:
What does this PR do?
This PR makes sure
renderFinally()is always called even ifanimationis disabled.Fixed issues
Details
Before: What was the problem?
In this screenshot, Alexia and Beth should have been removed (they were present in the first option, but were removed in the second option):

After: How is it fixed in this PR?
After the change, the names are removed correctly when calling

setOptionagain.Merging options
Other information