fix: issue#16749 colorAlpha check#16760
Conversation
|
Thanks for your contribution! |
|
It will bring First of all these two only do modification on the If we do so, we need to do more work to keep the consistent. For example, |
|
@pissang I agree, I think doing reduction is better than addition here. I would prefer removing colorAlpha from itemStyle because user can set opacity easily with rgba at color. Shall I submit another PR to try removing colorAlpha? |
|
@jiawulin001 Sure, we can deprecate it progressively. For example, we can remove it in the doc at first. Then using |
Brief Information
This pull request is in the type of:
What does this PR do?
Fix the problem where itemStyle.colorAlpha does not apply to the view.
Fixed issues
Details
Before: What was the problem?
The attribute itemStyle.colorAlpha is not working to change the opacity.

A rectangle applying
color = 'cyan'andcolorAlpha = 0.3has the same color as one applying only'color = 'cyan'.After: How is it fixed in this PR?
A simple check is added to Model.ts to see if

colorAlphacomes together withcolor. However this is adding details into model, which I think is not good.The result after fix is:
Code to reproduce
Misc