fix(custom): provide generic for itemStyle. close #16775#16921
Conversation
|
Thanks for your contribution! |
Rename TCbParams to CallbackDataParams
| ) => CustomSeriesRenderItemReturn; | ||
|
|
||
| export interface CustomSeriesOption extends | ||
| export interface CustomSeriesOption<CallbackDataParams = never> extends |
There was a problem hiding this comment.
Was this necessary? It seems to work without this line change and = never doesn't look a good way to define.
There was a problem hiding this comment.
I'm sorry for not getting back to you sooner. I had to provide never to minimize the needed change. If the "never" is omitted, it would require providing a generic argument to CustomSeriesOption, resulting in API changes.
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. We are sorry for this but 2 years is a long time and the code base has been changed a lot. Thanks for your contribution anyway. |
|
This PR has been automatically closed because it has not had recent activity. Sorry for that and we are looking forward to your next contribution. |
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes the TS error in case color is provided as a callback.
Fixed issues
#16775
Details
Before: What was the problem?
After: How is it fixed in this PR?
Now the generic parameter can be passed to CustomChart to properly define a callback for
colorproperty.Misc
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information