Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(axis): fix inverse option does not work for singleAxis #17411

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

wind108369
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

修复单轴反向的bug,原来属性定义的是inverse,在使用的时候是reverse

Fixed issues

Details

Before: What was the problem?

After: How does it behave after the fixing?

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jul 21, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reverse field can be removed. It may be an issue left over from history.

https://github.com/wind108369/echarts/blob/bugfix-single-inverse/src/coord/single/SingleAxis.ts#L46

@plainheart plainheart added this to the 5.4 milestone Jul 21, 2022
@plainheart plainheart changed the title 单轴反向失效问题修复 fix(axis): fix inverse option does not work for singleAxis Jul 21, 2022
pissang
pissang previously approved these changes Jul 21, 2022
@pissang pissang dismissed their stale review July 21, 2022 07:47

reverse field can be removed

@plainheart plainheart merged commit 8cdcc7d into apache:master Jul 22, 2022
@echarts-bot
Copy link

echarts-bot bot commented Jul 22, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@wind108369 wind108369 deleted the bugfix-single-inverse branch August 4, 2022 02:11
@Ovilia Ovilia modified the milestones: 5.4, 5.4.0 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants