fix(axis): containLabel work with multi axis without offset. fix #18077#18078
Closed
MeetzhDing wants to merge 1 commit intoapache:masterfrom
Closed
fix(axis): containLabel work with multi axis without offset. fix #18077#18078MeetzhDing wants to merge 1 commit intoapache:masterfrom
MeetzhDing wants to merge 1 commit intoapache:masterfrom
Conversation
|
Thanks for your contribution! |
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. We are sorry for this but 2 years is a long time and the code base has been changed a lot. Thanks for your contribution anyway. |
Contributor
|
This PR has been automatically closed because it has not had recent activity. Sorry for that and we are looking forward to your next contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
fix #18077 .
grid.containLabel will work better when multi axis.
Details
Before: What was the problem?
If you don‘t provide yAxis.offset, labels will overlay.
But every yAxis will take extra space in grid when grid.containLabel is true.
After: How does it behave after the fixing?
In
grid.containLabellogic, if axis.offset is not provided, it will calc bylabelUnionRect.Document Info
One of the following should be checked.