Skip to content

Comments

fix(axis): containLabel work with multi axis without offset. fix #18077#18078

Closed
MeetzhDing wants to merge 1 commit intoapache:masterfrom
MeetzhDing:fix/18077
Closed

fix(axis): containLabel work with multi axis without offset. fix #18077#18078
MeetzhDing wants to merge 1 commit intoapache:masterfrom
MeetzhDing:fix/18077

Conversation

@MeetzhDing
Copy link
Contributor

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

fix #18077 .

grid.containLabel will work better when multi axis.

Details

Before: What was the problem?

If you don‘t provide yAxis.offset, labels will overlay.
But every yAxis will take extra space in grid when grid.containLabel is true.

image

After: How does it behave after the fixing?

In grid.containLabel logic, if axis.offset is not provided, it will calc by labelUnionRect.

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

@echarts-bot
Copy link

echarts-bot bot commented Dec 19, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. We are sorry for this but 2 years is a long time and the code base has been changed a lot. Thanks for your contribution anyway.

@github-actions github-actions bot added the stale Inactive for a long time. Will be closed in 7 days. label Dec 19, 2024
@github-actions
Copy link
Contributor

This PR has been automatically closed because it has not had recent activity. Sorry for that and we are looking forward to your next contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: doc unchanged size/S stale Inactive for a long time. Will be closed in 7 days.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] grid.containLabel can't handle with multi yAxis, yAxis.label will overlap

1 participant