Skip to content

fix(DataZoom): dataZoom filter stack data unexpected(#18850)#18915

Closed
Mess663 wants to merge 1 commit intoapache:masterfrom
Mess663:fix-18850
Closed

fix(DataZoom): dataZoom filter stack data unexpected(#18850)#18915
Mess663 wants to merge 1 commit intoapache:masterfrom
Mess663:fix-18850

Conversation

@Mess663
Copy link
Copy Markdown

@Mess663 Mess663 commented Jul 20, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Correct the value window before seriesData.selectRange. Use the raw data to recalculate the value window, only in this case.

If you think this hotfix is not safe enough, i would love to make it better.

Fixed issues

#18850

Details

Before: What was the problem?

When config series {stack: 'Total', stackStrategy: 'all',} and toolbox.feature.dataZoom: {} , fill series data array with some nagative and positive number (like [2, -3, -14]), the value window may smaller then the max number in series data array. This value window problem is due to stack. So in this case, the number beyond this inappropriate value window will be filtered.

image

After: How does it behave after the fixing?

All data show up in right way.

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link
Copy Markdown

echarts-bot bot commented Jul 20, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

@Mess663 Mess663 changed the title fix(DataZoom): dataZoom filter stack Data unexpected(#18850) fix(DataZoom): dataZoom filter stack data unexpected(#18850) Jul 20, 2023
@Mess663 Mess663 closed this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant