Skip to content

fix decal in aria#19172

Closed
Aman1919 wants to merge 1 commit intoapache:masterfrom
Aman1919:first
Closed

fix decal in aria#19172
Aman1919 wants to merge 1 commit intoapache:masterfrom
Aman1919:first

Conversation

@Aman1919
Copy link
Copy Markdown
Contributor

@Aman1919 Aman1919 commented Oct 5, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixed issues

fixes - #18118

Details

Before: What was the problem?

series-sunburst.data.itemStyle.decal wasn't overriding aria.decal. decals

prev

After: How does it behave after the fixing?

series-sunburst.data.itemStyle.decal overriding aria.decal. decals

after

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link
Copy Markdown

echarts-bot bot commented Oct 5, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

Copy link
Copy Markdown
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've mentioned in your previous PR that the default decal of two sectors with different colors should be different. The result of the demo with this PR is not correct. It should be the same as the current behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants