Skip to content

Conversation

@Ruhshan
Copy link
Contributor

@Ruhshan Ruhshan commented Jul 6, 2023

… assertEquals

Fixes #4101 .

Motivation

expected and actual arguments were in wrong order for assertEquals usage in ClientConfigurationTest

Modifications

Corrected sequence for expected and actual arguments in assertEquals

Documentation

  • Does this pull request introduce a new feature? (no)

Copy link
Contributor

@Alonexc Alonexc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 changed the title [ISSUE # 4101]: Correct sequence for expected and actual arguments in… [ISSUE # 4101] Correct sequence for expected and actual arguments in… Jul 6, 2023
@xwm1992 xwm1992 changed the title [ISSUE # 4101] Correct sequence for expected and actual arguments in… [ISSUE # 4101] Correct sequence for expected and actual arguments in assertEquals Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #4189 (d18c9cf) into master (3392b45) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head d18c9cf differs from pull request most recent head a753c64. Consider uploading reports for the commit a753c64 to get more accurate results

@@             Coverage Diff              @@
##             master    #4189      +/-   ##
============================================
- Coverage     16.93%   16.92%   -0.01%     
+ Complexity     1413     1412       -1     
============================================
  Files           589      589              
  Lines         25789    25789              
  Branches       2397     2397              
============================================
- Hits           4368     4366       -2     
- Misses        20985    20986       +1     
- Partials        436      437       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 merged commit 42db065 into apache:master Jul 10, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Swap these 2 arguments so they are in the correct order.[ClientConfigurationTest]

6 participants