[ISSUE #4204] Repeat the code extraction as a method. #4229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!
Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!
Want to get closer to the community?
| WeChat Assistant | WeChat Public Account | Slack |
|---|---|---|
 |
 |
Join Slack Chat |
Mailing Lists:
| Name | Description | Subscribe | Unsubscribe | Archive |
|---|---|---|---|---|
| Users | User support and questions mailing list | Subscribe | Unsubscribe | Mail Archives |
| Development | Development related discussions | Subscribe | Unsubscribe | Mail Archives |
| Commits | All commits to repositories | Subscribe | Unsubscribe | Mail Archives |
| Issues | Issues or PRs comments and reviews | Subscribe | Unsubscribe | Mail Archives |
Pil0tXia
requested changes
Jul 15, 2023
Member
Pil0tXia
left a comment
Pil0tXia
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
...ain/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java
Show resolved
Hide resolved
Alonexc
approved these changes
Jul 17, 2023
Codecov Report
@@ Coverage Diff @@
## master #4229 +/- ##
============================================
- Coverage 16.90% 16.87% -0.04%
- Complexity 1416 1426 +10
============================================
Files 589 593 +4
Lines 25837 26063 +226
Branches 2394 2401 +7
============================================
+ Hits 4369 4398 +29
- Misses 21031 21224 +193
- Partials 437 441 +4
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xwm1992
previously approved these changes
Jul 17, 2023
lrhkobe
reviewed
Jul 18, 2023
...ain/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java
Outdated
Show resolved
Hide resolved
Pil0tXia
reviewed
Jul 18, 2023
...ain/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java
Outdated
Show resolved
Hide resolved
Pil0tXia
requested changes
Jul 19, 2023
...ain/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java
Outdated
Show resolved
Hide resolved
Pil0tXia
approved these changes
Jul 22, 2023
Member
Pil0tXia
left a comment
Pil0tXia
left a comment
There was a problem hiding this comment.
Well, +18 -18, no change in the number of lines but extracted a method. Acceptable.
mxsm
approved these changes
Jul 24, 2023
Member
Author
xwm1992
approved these changes
Jul 27, 2023
xuhongjia
pushed a commit
to Deckers-Ohana/eventmesh
that referenced
this pull request
Mar 13, 2025
…4229) * Repeat the code extraction as a method. * Do some code optimization.[util] * Do some code optimization.[util]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4204.
Modifications
Documentation