Skip to content

Conversation

@Ruhshan
Copy link
Contributor

@Ruhshan Ruhshan commented Jul 20, 2023

…eventmesh-storage-kafka

Fixes #4097 .

Motivation

File mentioned in the issue had duplicate keys.

Modifications

Removed the duplicate keys from the mentioned file.

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #4256 (269d51e) into master (4b994b0) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 269d51e differs from pull request most recent head 6ff7db4. Consider uploading reports for the commit 6ff7db4 to get more accurate results

@@             Coverage Diff              @@
##             master    #4256      +/-   ##
============================================
+ Coverage     16.75%   16.77%   +0.01%     
  Complexity     1415     1415              
============================================
  Files           592      592              
  Lines         26029    26032       +3     
  Branches       2384     2398      +14     
============================================
+ Hits           4362     4367       +5     
+ Misses        21230    21227       -3     
- Partials        437      438       +1     
Impacted Files Coverage Δ
...ache/eventmesh/runtime/util/HttpResponseUtils.java 23.07% <0.00%> (+1.64%) ⬆️
...apache/eventmesh/runtime/util/ValueComparator.java 25.00% <ø> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptable.

@xwm1992 xwm1992 changed the title [ISSUE #4097]: Remove duplicate keys from kafka-client properties in … [ISSUE #4097] Remove duplicate keys from kafka-client properties in eventmesh-storage-kafka Jul 21, 2023
@pandaapo pandaapo merged commit 3ad12c4 into apache:master Jul 22, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Duplicate property key

5 participants